Description

PR #56 removes the liquidity-side oracle output from TruncGeoOracleMulti.consult(). While this is consistent with a tick-only oracle design, it changes the function shape used by external integrations that still expect the previous consult() signature to return both the arithmetic mean tick and the harmonic mean liquidity.

As a result, downstream projects that depend on the existing interface may require unnecessary changes even if they do not rely on the harmonic mean liquidity value itself. This creates avoidable integration friction for consumers who only need ABI compatibility with the historical Oracle interface.

Recommendation

Consider restoring the previous consult() return shape in TruncGeoOracleMulti and returning 0 for the harmonic mean liquidity value if that metric is no longer supported by design.

Solo Labs: We have other contracts that expect a particular consult signature, and that might be the cleanest solution to just return 0 and keep the signature unchanged. Fixed: PR 57

Cantina: Fix review.

Security Assessment

PR #56 removes the add/remove liquidity hooks from Spot and removes the public liquidity-side oracle outputs from TruncGeoOracleMulti.

From a security perspective, these changes are consistent with a design where the oracle now exposes a tick-only public interface. In the previous design, the add/remove liquidity hooks existed to preserve liquidity sensitive oracle values across LP. Once those public liquidity-side outputs are removed, the main security-relevant reason for those hooks also disappears. The changes are coherent and do not introduce an obvious new attack surface in the core swap fee, reinvestment, or liquidity accounting paths.