## Description In `aave_oracle::oracle`, the module imports and relies on `aptos_std::smart_table` and declares in `PriceOracleData` three fields of type `SmartTable<…>`: ```move use aptos_std::smart_table; ... struct PriceOracleData has key { asset_feed_ids: SmartTable>, custom_asset_prices: SmartTable, capped_assets_data: SmartTable } ``` The Move standard library deprecated `SmartTable` in early 2024 and now recommends using `aptos_std::table::Table` for general maps or `aptos_std::big_ordered_map::BigOrderedMap` when ordering or large datasets are required. Continuing to use `SmartTable` risks compatibility with future Aptos releases, forfeits performance and feature improvements introduced in the newer collection types, and stands contrary to the current Aptos framework documentation and upgrades. Reliance on a removed‐soon API may break the oracle on framework upgrades and increases maintenance and gas costs. ## Proof of concept Add this test into `aave-core/aave-oracle/tests/oracle_tests.move`: ```move #[test(aave_oracle = @aave_oracle)] fun test_prove_deprecated_smart_table_usage(aave_oracle: &signer) { // init aave oracle oracle::test_init_oracle(aave_oracle); // ISSUE PROOF: This test demonstrates that the oracle module uses deprecated SmartTable APIs // The PriceOracleData struct contains three SmartTable fields that are deprecated: // - asset_feed_ids: smart_table::SmartTable> DEPRECATED // - custom_asset_prices: smart_table::SmartTable DEPRECATED // - capped_assets_data: smart_table::SmartTable DEPRECATED // These oracle operations internally call deprecated SmartTable functions: oracle::test_set_asset_custom_price(TEST_ASSET, TEST_ASSET_CUSTOM_PRICE); // calls smart_table::upsert() let price = oracle::test_get_asset_custom_price(TEST_ASSET); // calls smart_table::borrow() assert!(price == TEST_ASSET_CUSTOM_PRICE, TEST_SUCCESS); oracle::test_set_asset_feed_id(TEST_ASSET, TEST_FEED_ID); // calls smart_table::upsert() let feed_id = oracle::test_get_feed_id(TEST_ASSET); // calls smart_table::borrow() assert!(feed_id == TEST_FEED_ID, TEST_SUCCESS); // Clean up using more deprecated SmartTable operations oracle::test_remove_asset_custom_price(TEST_ASSET, TEST_ASSET_CUSTOM_PRICE); // calls smart_table::remove() oracle::test_remove_feed_id(TEST_ASSET, TEST_FEED_ID); // calls smart_table::remove() // SOLUTION: Replace SmartTable with aptos_std::table::Table // All smart_table:: calls should become table:: calls with identical signatures } ``` ## Recommendation Replace each `SmartTable` instance with the appropriate modern collection—`Table` for simple key–value needs or `BigOrderedMap` where ordering or scaling matters—and adjust all `add/borrow/remove` calls to the new API to restore full functionality under the latest Aptos framework.

Contest	Position	Date	Payout
aave-aptos	3 / 410	May 2025	$24,293
bima-money	6 / 341	December 2024	$7,927
velvet-v4	3 / 624	February 2025	$6,852
circuit-puzzles	11 / 506	May 2025	$468
VenusProtocol/governance-contracts	6 / 114	March 2024	$375

0xBeastBoy

Top competitions