Coinbase: Proof Contracts Update

Description

The new revocation mechanism allows the owner/revoker to revoke a certificate through the revokeCert() function.

However, the current logic requires this certificate to be trusted before being revokable.

function revokeCert(bytes32 certHash) external onlyOwnerOrRevoker {        if (trustedIntermediateCerts[certHash] == 0) { // @audit requires certificate to be trusted            revert CertificateNotFound(certHash);        }        delete trustedIntermediateCerts[certHash];        revokedCerts[certHash] = true;        emit CertRevoked(certHash);    }

In the scenario where a certificate private key has been compromised but this certificate is not yet recognized in the trustedIntermediateCerts, it is not possible to revoke this certificate in a safe way. Revoking this certificate is not possible without trusting it in the first place.

Recommendation

The trustedIntermediateCerts check should be removed from revokeCert() to ensure safe revocation of not-yet trusted certificates.

function revokeCert(bytes32 certHash) external onlyOwnerOrRevoker {-       if (trustedIntermediateCerts[certHash] == 0) {-           revert CertificateNotFound(certHash);-       }        delete trustedIntermediateCerts[certHash];        revokedCerts[certHash] = true;        emit CertRevoked(certHash);    }

Coinbase

Fixed in PR329.

Cantina

Fixed. The patch has been applied and the documentation is up-to-date.