.js","8720","static/chunks/8720-3125bd88670d99e5.js","9609","static/chunks/9609-17d1dfea95f65226.js","6738","static/chunks/6738-ab11dce0657a8f04.js","7775","static/chunks/app/(public)/u/%5Busername%5D/layout-cc6ec98cd59a8d53.js"],"ProfileTabs"] 27:T753,## Description 1. [DataPackage](https://cantina.xyz/code/8337db39-e04e-470d-8090-0cfb9a7ec2dd/redstone-fuel-sdk/src/protocol/data_package.sw#L8-L12) is used to store structured byte data ```Rust 8 pub struct DataPackage { 9 pub timestamp: u64, <<< --- the timestamp related to the packages 10 pub signer_address: b256, <<< --- the address who signs the package 11 pub data_points: Vec, <<< --- feed_id/value pairs stand for the price for feeds 12 } ``` 2. According to [Fuel's documents](https://docs.fuel.sh/v1.1.0/Concepts/Fundamentals/Deployment%20Parameters.html), there are two chains being used currently: `Mainnet(chainId: 1), and Rinkeby Testnet(chainId: 4)` With above information, if the contract is deployed on both mainnet and testnet, and both uses the same signers, then the `DataPackage` used on testnet can be replayed on mainnet. ## Recommendation Besides adding a `chain_id` member to `DataPackage`, I think it's better to add another member `verify_address` to prevent the data replayed on different contracts(like `verifyingContract` used in [EIP712](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md)) ```diff diff --git a/src/protocol/data_package.sw b/src/protocol/data_package.sw index 63a2283..6d18be1 100644 --- a/src/protocol/data_package.sw +++ b/src/protocol/data_package.sw @@ -5,8 +5,16 @@ use ::crypto::recover::recover_signer_address; use ::utils::{bytes::*, from_bytes::FromBytes, sample::SampleDataPackage, test_helpers::*, vec::*}; use ::protocol::{constants::*, data_point::DataPoint}; +use fuel_core_types::{ + fuel_types::{ + ChainId, + }, +}; + pub struct DataPackage { pub timestamp: u64, + pub chain_id: ChainId, + pub verifying_contract: b2

Contest	Position	Date	Payout
redstone-oracle	3 / 186	September 2024	$3,745
Blast	60 / 599	January 2024	$0

web3layman

Top competitions